kwin commented on code in PR #894: URL: https://github.com/apache/maven/pull/894#discussion_r1038069370
########## maven-core/src/main/resources/META-INF/maven/extension.xml: ########## @@ -136,6 +136,16 @@ under the License. </exportedPackages> <exportedArtifacts> + <!-- maven 4 api --> + <exportedArtifact>org.apache.maven:maven-api-core</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-api-meta</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-api-model</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-api-settings</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-api-toolchain</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-api-xml</exportedArtifact> + <exportedArtifact>org.apache.maven:maven-xml-impl</exportedArtifact> + <exportedArtifact>org.apache.maven:plexus-utils</exportedArtifact> Review Comment: I don't think this works, as only a handful of classes are actually exposed. For that reason the old plexus-utils was also not listed here. IIUC then listing an artifact here makes it impossible to add it explicitly to the class loader hierarchy (for a plugin or build extension) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
