gnodet commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038090672
##########
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##########
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
- private final MavenBuildTimestamp mavenBuildTimestamp;
+ private final Date startTime;
+ private final Map<String, String> properties;
BuildTimestampValueSource(Date startTime, Map<String, String> properties) {
Review Comment:
The problem is that the only usage is when using the
`ModelBuildingRequest.getBuildStartTime()`, which comes from
`ProjectBuildingRequest.getBuildStartTime()` and
`MavenExecutionRequest.getStartTime()`. Without modifying those, which are
public interfaces, there's no real value in changing this internal class.
Maybe when the core switches to the v4 api, as the start time is available
as an `Instant` on the `Session`, then it will make sense to switch. For now,
it will only add `Date` -> `Instant` conversions for no real value imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
