[
https://issues.apache.org/jira/browse/MNG-7614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642514#comment-17642514
]
ASF GitHub Bot commented on MNG-7614:
-------------------------------------
cstamas commented on code in PR #895:
URL: https://github.com/apache/maven/pull/895#discussion_r1038151549
##########
maven-core/src/main/java/org/apache/maven/internal/aether/DefaultRepositorySystemSessionFactory.java:
##########
@@ -209,6 +211,76 @@ public DefaultRepositorySystemSession
newRepositorySession(MavenExecutionRequest
XmlPlexusConfiguration config = new
XmlPlexusConfiguration(dom);
configProps.put("aether.connector.wagon.config." +
server.getId(), config);
+
+ // Translate to proper resolver configuration properties as
well (as Plexus XML above is Wagon specific
+ // only)
+ // but support only configuration/httpConfiguration/all, not
the per-method nonsense
+ //
https://maven.apache.org/guides/mini/guide-http-settings.html
+ Map<String, String> headers = null;
+ Integer connectTimeout = null;
+ Integer requestTimeout = null;
+
+ PlexusConfiguration httpHeaders =
config.getChild("httpHeaders", false);
+ if (httpHeaders != null) {
+ PlexusConfiguration[] properties =
httpHeaders.getChildren("property");
+ if (properties != null && properties.length > 0) {
+ headers = new HashMap<>();
+ for (PlexusConfiguration property : properties) {
+ headers.put(
+ property.getChild("name").getValue(),
+ property.getChild("value").getValue());
+ }
+ }
+ }
+
+ PlexusConfiguration connectTimeoutXml =
config.getChild("connectTimeout", false);
+ if (connectTimeoutXml != null) {
+ connectTimeout =
Integer.parseInt(connectTimeoutXml.getValue());
+ } else {
+ // fallback configuration name
+ PlexusConfiguration httpConfiguration =
config.getChild("httpConfiguration", false);
+ if (httpConfiguration != null) {
Review Comment:
that would mean am potentially mutating the config object (that is already
passed to Wagon as Plexus config)
> Maven should translate transport configuration fully to resolver transports.
> ----------------------------------------------------------------------------
>
> Key: MNG-7614
> URL: https://issues.apache.org/jira/browse/MNG-7614
> Project: Maven
> Issue Type: Improvement
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.0
>
>
> Maven should properly translate transport configuration, instead to assume
> Wagon.
> Master (Maven 4) got this fixed as part of MNG-7608, but for Maven 3.9.x this
> needs to be backported, as it got native transporter as part of MNG-7454 but
> confguration translation still needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
