mthmulders commented on code in PR #816:
URL: https://github.com/apache/maven/pull/816#discussion_r1038161348
##########
maven-model-builder/src/main/java/org/apache/maven/model/interpolation/BuildTimestampValueSource.java:
##########
@@ -23,17 +23,19 @@
import org.codehaus.plexus.interpolation.AbstractValueSource;
class BuildTimestampValueSource extends AbstractValueSource {
- private final MavenBuildTimestamp mavenBuildTimestamp;
+ private final Date startTime;
+ private final Map<String, String> properties;
BuildTimestampValueSource(Date startTime, Map<String, String> properties) {
Review Comment:
AFAICS, the `MavenBuildTimestamp` class takes care of properly applying the
`maven.build.timestamp.format` value, too. I think it's a bit too much to
inline all of that here. Let's leave it as is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
