[
https://issues.apache.org/jira/browse/MWRAPPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17654911#comment-17654911
]
ASF GitHub Bot commented on MWRAPPER-33:
----------------------------------------
timtebeek opened a new pull request, #80:
URL: https://github.com/apache/maven-wrapper/pull/80
Java 8 brought some possible code improvements over the previous Java 7.
These have been applied through:
```
mvn org.openrewrite.maven:rewrite-maven-plugin:4.38.2:run
-DactiveRecipes=org.openrewrite.java.cleanup.CommonStaticAnalysis
```
With the following results
```
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineParser.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.EqualsAvoidsNull
org.openrewrite.java.cleanup.FinalClass
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLineOption.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/CommandLineOption.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/ParsedCommandLine.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/main/java/org/apache/maven/wrapper/cli/AbstractPropertiesCommandLineConverter.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper/src/test/java/org/apache/maven/wrapper/SystemPropertiesHandlerTest.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseDiamondOperator
Changes have been made to
maven-wrapper-plugin/src/main/java/org/apache/maven/plugins/wrapper/WrapperMojo.java
by:
org.openrewrite.java.cleanup.CommonStaticAnalysis
org.openrewrite.java.cleanup.UseLambdaForFunctionalInterface
```
A few private classes have been made final, but I don't suppose that will be
an issue.
All of these changes were automated, so I don't feel particularly attached
to them/
Feel free to provide honest feedback if these types of changes are not
welcome! :)
----
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MWRAPPER) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line
and body.
- [x] Format the pull request title like `[MWRAPPER-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `MWRAPPER-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean
verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
> Use java 8 in maven-wrapper
> ---------------------------
>
> Key: MWRAPPER-33
> URL: https://issues.apache.org/jira/browse/MWRAPPER-33
> Project: Maven Wrapper
> Issue Type: Improvement
> Components: Maven Wrapper Jar
> Affects Versions: 3.1.0
> Reporter: Slawomir Jaranowski
> Assignee: Benjamin Marwell
> Priority: Major
> Labels: up-for-grabs
> Fix For: 3.2.0
>
>
> Currently {{maven-wrapper}} use java {*}5{*}.
> It blocks build project on java > 8.
> {{maven-wrapper-plugin}} require java 8, so we can use {{maven-wrapper}} with
> java 5 but we can't install it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
