gnodet commented on PR #232:
URL:
https://github.com/apache/maven-integration-testing/pull/232#issuecomment-1384539251
> > > I consider this wrong because they should be at most managed from
within Verifier. Those are _system_ properties and when these are required then
a _forked_ verifier must be used.
> >
> >
> > I don't really see how that's different from #232
> > Another possibility is to have the Verifier set this property explicitly
to the value `${maven.home}/conf`. And if you think it's wrong that the
Verifier change these properties, then let's do it in this PR as this won't
affect anyone else.
> > But really, having the tests not being isolated is a bad idea.
>
> I am not isolation, but isolation needs to happen by the framework
executing the tests and if necessary, create a new process for it.
Sorry, bad link above. I meant
https://github.com/apache/maven-verifier/blob/70789f300e3bb30dd3d57f4d81fbdeee7b0310ee/src/main/java/org/apache/maven/shared/verifier/Embedded3xLauncher.java#L202-L206
So, as @slawekjaranowski indicated, the two properties `maven.bootclasspath`
and `classworlds.conf` are actually input for the Verifier, so that's part of
the verifier's configuration, so they do belong here imho. Unless Verifier is
changed somehow, but at this point, I think it makes sense.
The third one, the `maven.conf` should be cleared by the verifier, but it's
also an input. So it's a possible valid use case to actually set the
`maven.conf`, so again, it can't really always be cleared by the verifier.
I think the problem is that the verifier should not use system properties to
configure itself and should be given a `Map<String, String>` from where it can
find various configuration bits to isolate the call to the verifier from the
environment. But that's a bigger change, so until the Verifier is improved and
change the way it's configured, I think this PR is a good workaround @michael-o
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
