gnodet commented on code in PR #954: URL: https://github.com/apache/maven/pull/954#discussion_r1071816860
########## maven-core/src/main/java/org/apache/maven/ReactorReader.java: ########## @@ -20,41 +20,33 @@ import javax.inject.Inject; import javax.inject.Named; +import javax.inject.Singleton; import java.io.File; import java.io.IOException; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; -import java.util.Arrays; -import java.util.Collection; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.List; -import java.util.Map; -import java.util.Objects; -import java.util.Optional; -import java.util.function.Function; +import java.nio.file.StandardCopyOption; +import java.util.*; Review Comment: > Also, I wonder if this change allows us to remove the fallbacks that were previously on line 150 - 159. Since those lines aren't changed, it seems GitHub doesn't allow me to comment on the spot :-\. Good question. I think part of it could be removed, we'll need to keep the `determineBuildOutputDirectoryForArtifact` in order to be able to partially run `mvn test`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
