[
https://issues.apache.org/jira/browse/MSITE-922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677972#comment-17677972
]
Michael Osipov commented on MSITE-922:
--------------------------------------
Yes, they have to fix. Let me elaborate: For 10+ years Doxia contained backward
compatible code which was marked as not correct. No one cared to fix plugins
because nothing was broken. Doxia 2 now cleans up 10+ years of luggage making
things strict and consistent. This is the code in question:
https://github.com/spotbugs/spotbugs-maven-plugin/blob/spotbugs/src/main/groovy/org/codehaus/mojo/spotbugs/SpotbugsReportGenerator.groovy
See the references I have provided you in wiki and MDEP. The fix for spotbugs
is as easy as
https://github.com/apache/maven-dependency-plugin/commit/4b478d61e1e78f5bddda6d1256f91c357c2561a4.
I have intentionally created new major version of all affected components to
denote that we may break things. Based on your experience I have created
MSKINS-208 and started a vote for 1.11.2. This will block all executions when
MSITE 4.0.0 isn't used.
> Using 4.0.0-M4 w/ maven-fluido-skin breaks table formatting in generated
> pages
> -------------------------------------------------------------------------------
>
> Key: MSITE-922
> URL: https://issues.apache.org/jira/browse/MSITE-922
> Project: Maven Site Plugin
> Issue Type: Bug
> Affects Versions: 4.0.0-M4
> Reporter: Dave Wichers
> Priority: Major
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> If, after you set the maven-site-plugin version to 4.0.0-M4 in the AntiSamy
> ([https://github.com/nahsra/antisamy]) pom.xml, you run: 'mvn site' against
> the main branch of this project:
> It generates the site docs just fine, but the tables are broken in many of
> the pages, which are rendered fine with the 4.0.0-M3 version of the
> maven-site-plugin.
> I did the following diff of 1 broken vs. OK generated site page file and
> here's what it shows:
> antisamy % diff target/site/spotbugs.html ../targetBroken/site/spotbugs.html
> 5c5
> {quote}< | Generated by Apache Maven Doxia Site Renderer 1.11.1 from
> com.github.spotbugs:spotbugs-maven-plugin:4.7.3.0:spotbugs at 2023-01-16
> ---
> > | Generated by Apache Maven Doxia Site Renderer 2.0.0-M4 from
> >com.github.spotbugs:spotbugs-maven-plugin:4.7.3.0:spotbugs at 2023-01-16
> 8c8
> < <html xmlns="http://www.w3.org/1999/xhtml"; lang="en">
> ---
> > <html xmlns="http://www.w3.org/1999/xhtml"; lang="">
> 12c12
> < <meta name="generator" content="Apache Maven Doxia Site Renderer
> 1.11.1" />
> ---
> > <meta name="generator" content="Apache Maven Doxia Site Renderer
> > 2.0.0-M4" />
> 70c70
> < <h2><a name="SpotBugs_Bug_Detector_Report"></a>SpotBugs Bug Detector
> Report</h2>
> ---
> > <h1>SpotBugs Bug Detector Report</h1>
> 75,76c75
> < <h2><a name="Summary"></a>Summary</h2>
> < <table border="0" class="table table-striped">
> ---
> > <h1>Summary</h1>
> 87,88c86
> < <h2><a name="Files"></a>Files</h2>
> < <table border="0" class="table table-striped">
> ---
> > <h1>Files</h1>
> 97,99c95,96
> < <td>1</td></tr></table></section><a
> name="org.owasp.validator.css.CssHandler"></a><section>
> < <h3><a
> name="org.owasp.validator.css.CssHandler"></a>org.owasp.validator.css.CssHandler</h3>
> < <table border="0" class="table table-striped">
> ---
> > <td>1</td></tr></table></section><a
> > id="org.owasp.validator.css.CssHandler"></a><section>
> > <h2>org.owasp.validator.css.CssHandler</h2>
> 123,125c120,121
> < <td>Medium</td></tr></table></section><a
> name="org.owasp.validator.css.CssScanner"></a><section>
> < <h3><a
> name="org.owasp.validator.css.CssScanner"></a>org.owasp.validator.css.CssScanner</h3>
> < <table border="0" class="table table-striped">
> ---
> > <td>Medium</td></tr></table></section><a
> > id="org.owasp.validator.css.CssScanner"></a><section>
> > <h2>org.owasp.validator.css.CssScanner</h2>
> {quote}
> Given that it works with 4.0.0-M3 this seems like a bug.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
