[
https://issues.apache.org/jira/browse/MARTIFACT-38?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683247#comment-17683247
]
Herve Boutemy commented on MARTIFACT-38:
----------------------------------------
I fully agree on adding a link to the plugin issue: let's show where the root
cause is and help people contribute on the issue
on failing the build, I understand the objective of showing clearly to users
not reading warnings that the build is not reproducible
but I have 2 problems:
1. in case of multi-module build, the detection of issues is stopped by failing
on the first module that has an issue: this does not permit to have a global
view
2. for some plugins, there are workarounds that you can apply (see post-process
cases, often with maven-replacer-plugin in
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/doc/BUILDSPEC.md
): failing will block these users
the minimum I think is to add a property to disable fail on non-reproducible
plugins
> Show failure reason and fail build if a plugin is marked as "fail"
> ------------------------------------------------------------------
>
> Key: MARTIFACT-38
> URL: https://issues.apache.org/jira/browse/MARTIFACT-38
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
> Affects Versions: 3.3.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.3.1
>
>
> currently, plugin shows a warning and continues:
> {noformat}
> [WARN] plugin without solution
> org.springframework.boot:spring-boot-maven-plugin:2.5.5
> {noformat}
> it would be better to report ERROR and the corresponding plugin issue (given
> it's provided in plugin issues config file:
> https://github.com/apache/maven-artifact-plugin/blob/master/src/main/resources/org/apache/maven/plugins/artifact/buildinfo/not-reproducible-plugins.properties
> )
> {noformat}
> [ERROR] plugin without solution
> org.springframework.boot:spring-boot-maven-plugin:2.5.5, see
> https://github.com/spring-projects/spring-boot/issues/21005
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
