[
https://issues.apache.org/jira/browse/MRESOLVER-319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685244#comment-17685244
]
ASF GitHub Bot commented on MRESOLVER-319:
------------------------------------------
cstamas commented on code in PR #240:
URL: https://github.com/apache/maven-resolver/pull/240#discussion_r1098533680
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -298,9 +306,11 @@ public void put( Collection<? extends ArtifactUpload>
artifactUploads,
Runnable task = new PutTaskRunner( location, transfer.getFile(),
transfer.getFileTransformer(),
checksumLocations, listener );
- task.run();
+ executor.execute( errorForwarder.wrap( task ) );
}
+ errorForwarder.await(); // make sure all artifacts are PUT before we
go with Metadata
+
Review Comment:
yes
##########
maven-resolver-connector-basic/src/main/java/org/eclipse/aether/connector/basic/BasicRepositoryConnector.java:
##########
@@ -298,9 +306,11 @@ public void put( Collection<? extends ArtifactUpload>
artifactUploads,
Runnable task = new PutTaskRunner( location, transfer.getFile(),
transfer.getFileTransformer(),
checksumLocations, listener );
- task.run();
+ executor.execute( errorForwarder.wrap( task ) );
}
+ errorForwarder.await(); // make sure all artifacts are PUT before we
go with Metadata
+
Review Comment:
yes, hence the name
> Support parallel deploy
> -----------------------
>
> Key: MRESOLVER-319
> URL: https://issues.apache.org/jira/browse/MRESOLVER-319
> Project: Maven Resolver
> Issue Type: New Feature
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.5
>
>
> Basic connector is able to perform parallel fetches. In same way, connector
> should be improved to perform parallel uploads.
> The new feature should be "dormant" by default (as every new feature), but
> user should be able to enable it via configuration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
