tbw777 commented on code in PR #988: URL: https://github.com/apache/maven/pull/988#discussion_r1099842746
########## maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java: ########## @@ -68,7 +68,7 @@ @Singleton public class DefaultModelValidator implements ModelValidator { - private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile("\\$\\{(.+?)\\}"); + private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile("\\$\\{(.+?)}"); Review Comment: I think first entry is escaping ########## maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java: ########## @@ -68,7 +68,7 @@ @Singleton public class DefaultModelValidator implements ModelValidator { - private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile("\\$\\{(.+?)\\}"); + private static final Pattern CI_FRIENDLY_EXPRESSION = Pattern.compile("\\$\\{(.+?)}"); Review Comment: I think the first entry is escaping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org