[
https://issues.apache.org/jira/browse/MRESOLVER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17685957#comment-17685957
]
ASF GitHub Bot commented on MRESOLVER-320:
------------------------------------------
cstamas commented on code in PR #241:
URL: https://github.com/apache/maven-resolver/pull/241#discussion_r1100314432
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java:
##########
@@ -80,14 +76,14 @@ public DataPool( RepositorySystemSession session )
if ( cache != null )
{
- artifacts = (ObjectPool<Artifact>) cache.get( session,
ARTIFACT_POOL );
- dependencies = (ObjectPool<Dependency>) cache.get( session,
DEPENDENCY_POOL );
- descriptors = (Map<Object, WeakReference<Descriptor>>) cache.get(
session, DESCRIPTORS );
+ artifacts = (ConcurrentHashMap<Artifact, Artifact>) cache.get(
session, ARTIFACT_POOL );
+ dependencies = (ConcurrentHashMap<Dependency, Dependency>)
cache.get( session, DEPENDENCY_POOL );
+ descriptors = (ConcurrentHashMap<Object, Descriptor>) cache.get(
session, DESCRIPTORS );
Review Comment:
Well, we could of course, but if you look at class
https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/RepositoryCache.java
It is not marked as "noextend", hence it would be a breaking change =>
resolver major version. In fact, I think m2e does implement this class, this
was one of the main reasons to introduce it AFAIR. This class is very
differernt than SessionData, that is NOT meant to be implemented outside of
resolver....
> Investigate slower resolving speeds as reported by users
> --------------------------------------------------------
>
> Key: MRESOLVER-320
> URL: https://issues.apache.org/jira/browse/MRESOLVER-320
> Project: Maven Resolver
> Issue Type: Task
> Affects Versions: 1.9.4
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.5
>
>
> Users on ML reported "slowness" that MAY be caused by a change added in 1.9.0
> version of resolver MRESOLVER-250.
> [https://lists.apache.org/thread/r9p236z8kvqqk7ykvkgmc5wgps6n1hkf]
> [https://github.com/apache/maven-resolver/pull/166#issuecomment-1413808333]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
