gnodet commented on code in PR #241:
URL: https://github.com/apache/maven-resolver/pull/241#discussion_r1100517830
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java:
##########
@@ -80,14 +76,14 @@ public DataPool( RepositorySystemSession session )
if ( cache != null )
{
- artifacts = (ObjectPool<Artifact>) cache.get( session,
ARTIFACT_POOL );
- dependencies = (ObjectPool<Dependency>) cache.get( session,
DEPENDENCY_POOL );
- descriptors = (Map<Object, WeakReference<Descriptor>>) cache.get(
session, DESCRIPTORS );
+ artifacts = (ConcurrentHashMap<Artifact, Artifact>) cache.get(
session, ARTIFACT_POOL );
+ dependencies = (ConcurrentHashMap<Dependency, Dependency>)
cache.get( session, DEPENDENCY_POOL );
+ descriptors = (ConcurrentHashMap<Object, Descriptor>) cache.get(
session, DESCRIPTORS );
Review Comment:
As of Chapter 13. of the
[JLS](https://docs.oracle.com/javase/specs/jls/se8/html/jls-13.html#jls-13.5.3):
> Adding a default method, or changing a method from abstract to default,
does not break compatibility with pre-existing binaries, but may cause an
IncompatibleClassChangeError if a pre-existing binary attempts to invoke the
method.
Such usage is unexpected to say the least, so japicmp goes on the safe side,
but that should not be a problem really. See
https://github.com/siom79/japicmp/issues/201
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
