gnodet commented on PR #160:
URL:
https://github.com/apache/maven-compiler-plugin/pull/160#issuecomment-1424518900
I agree to drop the "incremental" boolean parameter, but not the default
behaviour. Not for performance reasons, but just because the output much more
often broken when you're developing : when setting `incremental` to `false`,
the stale check is not done and the compiler only rebuilds the changed files,
even if you changed a dependency. What this means is that if you change a
method signature, do a `verify`, the build works, but it will fail at runtime.
Example steps on `maven`:
* change the compiler globally by adding:
```
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<useIncrementalCompilation>false</useIncrementalCompilation>
</configuration>
</plugin>
``` in the main pom.xml
* run `mvn install -DskipTests`
* edit the
`api/maven-api-core/src/main/java/org/apache/maven/api/Dependency.java` and
change the return type of the `isOptional()` method to a `String`
* run `mvn install -DskipTests`
The build succeeds, whereas if you run `mvn clean install -DskipTests`, it
will fail.
So I'm +1 to get rid of the `useIncrementalCompilation=false` behaviour, but
definitely not the `useIncrementalCompilation=true` one. I'm also +1 to stop
calling it _incremental_.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
