[jira] [Comment Edited] (MNG-7689) NPE when calling dependency:analyze

Thu, 09 Feb 2023 14:00:41 -0800 


    [ 
https://issues.apache.org/jira/browse/MNG-7689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17686782#comment-17686782
 ] 

Alexey Venderov edited comment on MNG-7689 at 2/9/23 9:59 PM:
--------------------------------------------------------------

[~gnodet]Β added the fix.

The new version doesn't produce the {{{}NullPointerException{}}}:
{code:java}
πŸ•™ 22:54:02 ➜ ~/tmp/maven/dist/apache-maven-4.0.x-MNG-7689/bin/mvn --version
Apache Maven 4.0.0-alpha-5-SNAPSHOT (7b38457506544854cdd26aa1d49608050217b923)
Maven home: /Users/avenderov/tmp/maven/dist/apache-maven-4.0.x-MNG-7689
Java version: 11.0.17, vendor: Azul Systems, Inc., runtime: 
/Users/avenderov/.asdf/installs/java/zulu-11.60.19/zulu-11.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "12.6.3", arch: "aarch64", family: "mac"
~/dev/github/avenderov/maven-dependency-analyze-npe on ξ‚  main 514ms
πŸ•™ 22:54:08 ➜ ~/tmp/maven/dist/apache-maven-4.0.x-MNG-7689/bin/mvn 
dependency:analyze
[INFO] Scanning for projects...
[INFO]
[INFO] ----------------------------------< 
com.github.avenderov:maven-dependency-analyze-npe 
>-----------------------------------
[INFO] Building maven-dependency-analyze-npe 0.0.1-SNAPSHOT
[INFO]   from pom.xml
[INFO] ---------------------------------------------------------[ jar 
]----------------------------------------------------------
[INFO]
[INFO] >>> dependency:3.5.0:analyze (default-cli) > test-compile @ 
maven-dependency-analyze-npe >>>
[INFO]
[INFO] --- resources:3.3.0:resources (default-resources) @ 
maven-dependency-analyze-npe ---
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/main/resources
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/main/resources-filtered
[INFO]
[INFO] --- compiler:3.10.1:compile (default-compile) @ 
maven-dependency-analyze-npe ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- resources:3.3.0:testResources (default-testResources) @ 
maven-dependency-analyze-npe ---
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/test/resources
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/test/resources-filtered
[INFO]
[INFO] --- compiler:3.10.1:testCompile (default-testCompile) @ 
maven-dependency-analyze-npe ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] <<< dependency:3.5.0:analyze (default-cli) < test-compile @ 
maven-dependency-analyze-npe <<<
[INFO]
[INFO]
[INFO] --- dependency:3.5.0:analyze (default-cli) @ 
maven-dependency-analyze-npe ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.junit.jupiter:junit-jupiter-api:jar:5.9.2:test
[WARNING] Unused declared dependencies found:
[WARNING]    org.junit.jupiter:junit-jupiter:jar:5.9.2:test
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] Total time:  0.933 s
[INFO] Finished at: 2023-02-09T22:54:22+01:00
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
{code}


was (Author: avenderov):
Added the fix.

The new version doesn't produce the {{{}NullPointerException{}}}:
{code:java}
πŸ•™ 22:54:02 ➜ ~/tmp/maven/dist/apache-maven-4.0.x-MNG-7689/bin/mvn --version
Apache Maven 4.0.0-alpha-5-SNAPSHOT (7b38457506544854cdd26aa1d49608050217b923)
Maven home: /Users/avenderov/tmp/maven/dist/apache-maven-4.0.x-MNG-7689
Java version: 11.0.17, vendor: Azul Systems, Inc., runtime: 
/Users/avenderov/.asdf/installs/java/zulu-11.60.19/zulu-11.jdk/Contents/Home
Default locale: en_DE, platform encoding: UTF-8
OS name: "mac os x", version: "12.6.3", arch: "aarch64", family: "mac"
~/dev/github/avenderov/maven-dependency-analyze-npe on ξ‚  main 514ms
πŸ•™ 22:54:08 ➜ ~/tmp/maven/dist/apache-maven-4.0.x-MNG-7689/bin/mvn 
dependency:analyze
[INFO] Scanning for projects...
[INFO]
[INFO] ----------------------------------< 
com.github.avenderov:maven-dependency-analyze-npe 
>-----------------------------------
[INFO] Building maven-dependency-analyze-npe 0.0.1-SNAPSHOT
[INFO]   from pom.xml
[INFO] ---------------------------------------------------------[ jar 
]----------------------------------------------------------
[INFO]
[INFO] >>> dependency:3.5.0:analyze (default-cli) > test-compile @ 
maven-dependency-analyze-npe >>>
[INFO]
[INFO] --- resources:3.3.0:resources (default-resources) @ 
maven-dependency-analyze-npe ---
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/main/resources
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/main/resources-filtered
[INFO]
[INFO] --- compiler:3.10.1:compile (default-compile) @ 
maven-dependency-analyze-npe ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] --- resources:3.3.0:testResources (default-testResources) @ 
maven-dependency-analyze-npe ---
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/test/resources
[INFO] skip non existing resourceDirectory 
/Users/avenderov/dev/github/avenderov/maven-dependency-analyze-npe/src/test/resources-filtered
[INFO]
[INFO] --- compiler:3.10.1:testCompile (default-testCompile) @ 
maven-dependency-analyze-npe ---
[INFO] Nothing to compile - all classes are up to date
[INFO]
[INFO] <<< dependency:3.5.0:analyze (default-cli) < test-compile @ 
maven-dependency-analyze-npe <<<
[INFO]
[INFO]
[INFO] --- dependency:3.5.0:analyze (default-cli) @ 
maven-dependency-analyze-npe ---
[WARNING] Used undeclared dependencies found:
[WARNING]    org.junit.jupiter:junit-jupiter-api:jar:5.9.2:test
[WARNING] Unused declared dependencies found:
[WARNING]    org.junit.jupiter:junit-jupiter:jar:5.9.2:test
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
[INFO] Total time:  0.933 s
[INFO] Finished at: 2023-02-09T22:54:22+01:00
[INFO] 
--------------------------------------------------------------------------------------------------------------------------
{code}

> NPE when calling dependency:analyze
> -----------------------------------
>
>                 Key: MNG-7689
>                 URL: https://issues.apache.org/jira/browse/MNG-7689
>             Project: Maven
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 4.0.0-alpha-4
>         Environment: Linux, MacOS, Windows
>            Reporter: Alexey Venderov
>            Priority: Minor
>         Attachments: Screenshot 2023-02-09 at 21.33.02.png
>
>
> Hi,
> When using {{Maven 4.0.0-alpha4}} and invoking {{dependency:analyze}} goal 
> the {{NullPointerException}} is happening. I've created a simple reproducer: 
> https://github.com/c00ler/maven-dependency-analyze-npe
> The exception is happening 
> [here|https://github.com/apache/maven/blob/7b38457506544854cdd26aa1d49608050217b923/maven-core/src/main/java/org/apache/maven/ReactorReader.java#L323].
>  I assume, since {{analyze}} is a standalone goal, the {{lifecyclePhase}} is 
> {{null}} in the event (see the attached screenshot). This is a recent change: 
> https://github.com/apache/maven/commit/c1a900190f6e0fccf23889cb32f701459babfb7f,
>  only {{4.0.0-alpha4}} is affected.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to