[
https://issues.apache.org/jira/browse/MRESOLVER-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17688729#comment-17688729
]
ASF GitHub Bot commented on MRESOLVER-320:
------------------------------------------
psiroky commented on PR #243:
URL: https://github.com/apache/maven-resolver/pull/243#issuecomment-1430456033
I will run some more tests tomorrow. So far I just tried to run the
`validate -Dversion.enforcer.plugin=3.2.1 -T8` (on Quarkus again), which seems
to be almost on par with Maven 3.8.7 (9s vs 9.3s, and vs 11s for Maven 3.9.0).
However, I also got this exception in one of the runs
```
Caused by: java.lang.NullPointerException: Cannot invoke
"org.eclipse.aether.graph.Dependency.getArtifact()" because "dependency" is null
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollectionContext.set
(DefaultDependencyCollectionContext.java:75)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse
(DfDependencyCollector.java:261)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency
(DfDependencyCollector.java:236)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency
(DfDependencyCollector.java:137)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process
(DfDependencyCollector.java:125)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doRecurse
(DfDependencyCollector.java:284)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency
(DfDependencyCollector.java:236)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.processDependency
(DfDependencyCollector.java:137)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.process
(DfDependencyCollector.java:125)
at
org.eclipse.aether.internal.impl.collect.df.DfDependencyCollector.doCollectDependencies
(DfDependencyCollector.java:107)
at
org.eclipse.aether.internal.impl.collect.DependencyCollectorDelegate.collectDependencies
(DependencyCollectorDelegate.java:247)
at
org.eclipse.aether.internal.impl.collect.DefaultDependencyCollector.collectDependencies
(DefaultDependencyCollector.java:95)
at
org.eclipse.aether.internal.impl.DefaultRepositorySystem.collectDependencies
(DefaultRepositorySystem.java:327)
at
org.apache.maven.enforcer.rules.dependency.ResolveUtil.resolveTransitiveDependencies
(ResolveUtil.java:101)
at
org.apache.maven.enforcer.rules.dependency.DependencyConvergence.execute
(DependencyConvergence.java:65)
at org.apache.maven.plugins.enforcer.EnforceMojo.executeRuleNew
(EnforceMojo.java:351)
at org.apache.maven.plugins.enforcer.EnforceMojo.executeRule
(EnforceMojo.java:325)
at org.apache.maven.plugins.enforcer.EnforceMojo.execute
(EnforceMojo.java:248)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:126)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:342)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:330)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:213)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:175)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:76)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:163)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:160)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
(MultiThreadedBuilder.java:193)
at
org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call
(MultiThreadedBuilder.java:180)
at java.util.concurrent.FutureTask.run (FutureTask.java:317)
at java.util.concurrent.Executors$RunnableAdapter.call
(Executors.java:577)
at java.util.concurrent.FutureTask.run (FutureTask.java:317)
at java.util.concurrent.ThreadPoolExecutor.runWorker
(ThreadPoolExecutor.java:1144)
at java.util.concurrent.ThreadPoolExecutor$Worker.run
(ThreadPoolExecutor.java:642)
at java.lang.Thread.run (Thread.java:1589)
```
I am not sure if this is related to these changes, but it seemed suspicious
as it is coming from the `DfDependencyCollector`, so figured I would mention it
here. It is quite rare, I only got this error once in 100 runs (so maybe this
there all the time and I was just "lucky" to never encounter it). In any case,
it seems like something we should eventually take a look at.
> Investigate slower resolving speeds as reported by users
> --------------------------------------------------------
>
> Key: MRESOLVER-320
> URL: https://issues.apache.org/jira/browse/MRESOLVER-320
> Project: Maven Resolver
> Issue Type: Task
> Components: Resolver
> Affects Versions: 1.9.4
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.5
>
>
> Users on ML reported "slowness" that MAY be caused by a change added in 1.9.0
> version of resolver MRESOLVER-250.
> [https://lists.apache.org/thread/r9p236z8kvqqk7ykvkgmc5wgps6n1hkf]
> [https://github.com/apache/maven-resolver/pull/166#issuecomment-1413808333]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
