gnodet commented on issue #787:
URL: https://github.com/apache/maven-mvnd/issues/787#issuecomment-1433798069

   > > I'm fine with removing 0.9.0 for now or any other quick fix. Not sure 
how to do that though.
   > 
   > Great, you can remove any version using our API, it has a DELETE method. 
If you struggle I can help. Also, you would need to make 0.8.9 the new 
candidate default.
   
   ```
   > for PLATFORM in LINUX_64 MAC_OSX MAC_ARM64 WINDOWS_64
     do curl -s -X DELETE \
       -H "Consumer-Key: ${SDKMAN_CONSUMER_KEY}" \
       -H "Consumer-Token: ${SDKMAN_CONSUMER_TOKEN}" \
       -H "Content-Type: application/json" \
       -H "Accept: application/json" \
       -d '{"candidate": "mvnd", "version": "0.9.0", "platform": 
"'${PLATFORM}'"}' \
      https://vendors.sdkman.io/release
   done
   {"message":"Conflict: mvnd 0.9.0 
LINUX_64","status":409}{"message":"Conflict: mvnd 0.9.0 
MAC_OSX","status":409}{"message":"Conflict: mvnd 0.9.0 
MAC_ARM64","status":409}{"message":"Conflict: mvnd 0.9.0 
WINDOWS_64","status":409}
   ```                                                                          
          
   
   > > Though I don't understand how the fact that mvnd is multiplatform is 
relevant.
   > 
   > This is very relevant as SDKMAN classifies this at a candidate level. 
Besides the fact that it simply isn't possible, I also don't feel comfortable 
adding mvnd to the Maven candidate.
   
   I've been testing that locally (by using `sdk install maven 0.9.0 
/path/to/mvnd-0.9.0` and similar other calls, and this seems to work fine 
enough for me.   I'll experiment a bit more.  I'm actually working on modifying 
_mvnd_ to support maven 3.9.x and 4.0.x with two different distributions 
generated from the same source tree (i.e. a single maven build / release would 
produce 2 distributions for a given platform, one embedding maven 3.9.x and 
another one embedding 4.0.x).
   
   For the platform, I think it would make sense to publish a `UNIVERSAL` 
distribution containing just the `mvnd.sh` script as indicated by 
https://sdkman.io/vendors#endpoints in addition to the distributions containing 
the native `mvnd` binary.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to