tbw777 commented on code in PR #998:
URL: https://github.com/apache/maven/pull/998#discussion_r1110337752
##########
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##########
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
public static final String PROJECT_LOCAL_REPO = "project-local-repo";
- private static final Collection<String> COMPILE_PHASE_TYPES =
- Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client");
+ private static final Set<String> COMPILE_PHASE_TYPES;
+
+ static {
+ COMPILE_PHASE_TYPES = new HashSet<>(
+ Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3",
"par", "sar", "wsr", "har", "app-client"));
+ }
Review Comment:
https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32
```java
private static final Collection<String> COMPILE_PHASE_TYPES_LIST =
Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client");
private static final Set<String> COMPILE_PHASE_TYPES_SET = new HashSet<>(
Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client"));
@Benchmark
public void COMPILE_PHASE_TYPES() {
boolean ejb3 = COMPILE_PHASE_TYPES_LIST.contains(str);
}
@Benchmark
public void COMPILE_PHASE_TYPES_SET() {
boolean ejb3 = COMPILE_PHASE_TYPES_SET.contains(str);
}
```
##########
maven-core/src/main/java/org/apache/maven/ReactorReader.java:
##########
@@ -69,8 +61,12 @@ class ReactorReader implements MavenWorkspaceReader {
public static final String PROJECT_LOCAL_REPO = "project-local-repo";
- private static final Collection<String> COMPILE_PHASE_TYPES =
- Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client");
+ private static final Set<String> COMPILE_PHASE_TYPES;
+
+ static {
+ COMPILE_PHASE_TYPES = new HashSet<>(
+ Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3",
"par", "sar", "wsr", "har", "app-client"));
+ }
Review Comment:
https://gist.github.com/tbw777/716907b110df7eac1792de7148f8eb32
```java
private static final Collection<String> COMPILE_PHASE_TYPES_LIST =
Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client");
private static final Set<String> COMPILE_PHASE_TYPES_SET = new HashSet<>(
Arrays.asList("jar", "ejb-client", "war", "rar", "ejb3", "par",
"sar", "wsr", "har", "app-client"));
@Benchmark
public void COMPILE_PHASE_TYPES() {
boolean ejb3 = COMPILE_PHASE_TYPES_LIST.contains(str);
}
@Benchmark
public void COMPILE_PHASE_TYPES_SET() {
boolean ejb3 = COMPILE_PHASE_TYPES_SET.contains(str);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
