psiroky commented on code in PR #238:
URL:
https://github.com/apache/maven-integration-testing/pull/238#discussion_r1117965421
##########
core-it-support/core-it-javaagent/pom.xml:
##########
@@ -53,6 +53,17 @@ under the License.
<goals>
<goal>shade</goal>
</goals>
+ <configuration>
+ <filters>
+ <filter>
+ <artifact>*:*</artifact>
+ <excludes>
+ <exclude>module-info.class</exclude>
+ <exclude>META-INF/MANIFEST.MF</exclude>
Review Comment:
Nice catch, thanks! I would have hoped that "something" would fail the build
if those manifest entries are missing -- seeing the linked PR, I assume this is
only failing with Maven 4.x, which is currently not part of PR checks.
In any case, I adjusted the filter to exclude only the `asm` artifacts,
which should fix the issue (the build still won't pass with Maven 4.x, but the
reported errors/failures seem to be consistent with the ones I am seeing on
master branch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
