[
https://issues.apache.org/jira/browse/MRESOLVER-329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693549#comment-17693549
]
ASF GitHub Bot commented on MRESOLVER-329:
------------------------------------------
michael-o commented on code in PR #257:
URL: https://github.com/apache/maven-resolver/pull/257#discussion_r1117990047
##########
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultTrackingFileManager.java:
##########
@@ -75,6 +76,8 @@ public Properties update(File file, Map<String, String>
updates) {
if (Files.isReadable(filePath)) {
try (InputStream stream = Files.newInputStream(filePath)) {
props.load(stream);
+ } catch (NoSuchFileException e) {
+ // MRESOLVER-329: ignore; in case of concurrent r/w
Files.isReadable may return true
Review Comment:
Please move this to another PR, both issues aren't necessarily related.
##########
maven-resolver-util/src/main/java/org/eclipse/aether/util/FileUtils.java:
##########
@@ -105,7 +106,16 @@ public Path getPath() {
@Override
public void move() throws IOException {
- Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE);
+ try {
+ Files.move(tempFile, file, StandardCopyOption.ATOMIC_MOVE);
+ } catch (AccessDeniedException e) {
+ // MRESOLVER-329: fallback to plain copy+rm, this usually
happens on Windows
Review Comment:
MRESOLVER-325 and not 329
> Make IO in DefaultTrackingFileManager more robust
> -------------------------------------------------
>
> Key: MRESOLVER-329
> URL: https://issues.apache.org/jira/browse/MRESOLVER-329
> Project: Maven Resolver
> Issue Type: Improvement
> Components: Resolver
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 1.9.6
>
>
> There are couple of spots where implementation naively assumes is alone
> running process on this world. Several user reports suggests this is not the
> case, like MRESOLVER-325 or MNG-7705. Fix these spots.
> Still, something is fishy, as it seems these files (all that are handled by
> DefaultTrackingFileManager) are not subject to locking? This needs
> investigation.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
