kwin commented on code in PR #146:
URL: https://github.com/apache/maven-doxia/pull/146#discussion_r1118085653


##########
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventElement.java:
##########
@@ -80,4 +80,22 @@ public String toString() {
         builder.append(']');
         return builder.toString();
     }
+
+    @Override
+    public int hashCode() {

Review Comment:
   Those is a test class only! I don't think adding test for testing utilities 
is very useful. Tests will fail if those don't work!



##########
doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/SinkEventElement.java:
##########
@@ -80,4 +80,22 @@ public String toString() {
         builder.append(']');
         return builder.toString();
     }
+
+    @Override
+    public int hashCode() {

Review Comment:
   This is a test class only! I don't think adding test for testing utilities 
is very useful. Tests will fail if those don't work!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to