[
https://issues.apache.org/jira/browse/DOXIATOOLS-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17693713#comment-17693713
]
ASF GitHub Bot commented on DOXIATOOLS-80:
------------------------------------------
michael-o commented on code in PR #41:
URL:
https://github.com/apache/maven-doxia-converter/pull/41#discussion_r1118153892
##########
pom.xml:
##########
@@ -173,17 +123,35 @@ under the License.
<artifactId>icu4j</artifactId>
<version>72.1</version>
</dependency>
-
+ <dependency>
+ <groupId>org.slf4j</groupId>
+ <artifactId>slf4j-api</artifactId>
+ <version>1.7.36</version>
+ </dependency>
+ <dependency>
+ <groupId>ch.qos.logback</groupId>
+ <artifactId>logback-classic</artifactId>
+ <version>1.2.11</version>
+ </dependency>
Review Comment:
Why not SLF4J simple with runtime scope?
##########
src/main/java/org/apache/maven/doxia/DefaultConverter.java:
##########
@@ -370,23 +335,21 @@ private void parse(
File outputDirectoryOrFile = relativeOutputDirectory != null
? new File(output.getFile(), relativeOutputDirectory.getPath())
: output.getFile();
- if (getLog().isDebugEnabled()) {
- getLog().debug("Parsing file from '" + inputFile.getAbsolutePath()
+ "' with the encoding '"
- + inputEncoding + "' to '" +
outputDirectoryOrFile.getAbsolutePath()
- + "' with the encoding '" + output.getEncoding() + "'");
- }
+ LOGGER.debug(
+ "Parsing file from '{}' with the encoding '{}'" + " to '{}'
with the encoding '{}'",
Review Comment:
Why not make it one string now?
##########
src/main/java/org/apache/maven/doxia/cli/ConverterCli.java:
##########
@@ -100,11 +98,9 @@ private static int doMain(String[] args) {
}
Converter converter = new DefaultConverter();
- Log log = new SystemStreamLog();
if (debug) {
- log.setLogLevel(Log.LEVEL_DEBUG);
+ // TODO: programmatically adjust log level
}
Review Comment:
Why then not drop the empty `if` clause?
> Update to Doxia 2.x
> -------------------
>
> Key: DOXIATOOLS-80
> URL: https://issues.apache.org/jira/browse/DOXIATOOLS-80
> Project: Maven Doxia Tools
> Issue Type: Improvement
> Components: Doxia Converter
> Reporter: Konrad Windszus
> Assignee: Konrad Windszus
> Priority: Major
> Fix For: doxia-converter-1.4
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
