[
https://issues.apache.org/jira/browse/MNG-6889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694407#comment-17694407
]
Tamas Cservenak edited comment on MNG-6889 at 2/28/23 8:11 AM:
---------------------------------------------------------------
IMO, there are several issues not understood well here, but for this issue, I
think we have to:
* deprecate it in 3.9.x (personally I'd just remove it as Karl Heinz said)
* remove it in 4.x.x
This flag not only introduces confusion (as it has several ways to be set
({{{}-llr-{}}},{{{}-legacy-local-repository{}}},
{{{}-Dmaven.legacyLocalRepo=true{}}}) there is also another setting for this in
resolver (see [https://maven.apache.org/resolver/configuration.html] for
{{aether.artifactResolver.simpleLrmInterop}} config). So essentially we handle
here 3 ways to achieve same functionality.
But, what is worse IMHO, is that Maven 3 with --help advertises Maven2 support,
that should be immediately stopped.
Personally (I was unaware of this issue) I'd just remove this option, hence
created MNG-7713 a duplicate of this issue (and PR), but would agree to
deprecate it.
More about WHY this option is WRONG and BAD will be added to MNG-7001.
was (Author: cstamas):
IMO, there are several issues not understood well here, but for this issue, I
think we have to:
* deprecate it in 3.9.x (personally I'd just remove it as Karl Heinz said)
* remove it in 4.x.x
This flag not only introduces confusion (as it has several ways to be set
({{{}-llr-{}}},{{{}-legacy-local-repository{}}},
{{{}-Dmaven.legacyLocalRepo=true{}}}) there is also another setting for this in
resolver (see [https://maven.apache.org/resolver/configuration.html] for
{{aether.artifactResolver.simpleLrmInterop}} config). So essentially we handle
here 3 ways to achieve same.
But, what is worse IMHO, is that Maven 3 with --help advertises Maven2 support,
that should be immediately stopped.
Personally (I was unaware of this issue) I'd just remove this option, hence
created MNG-7713 a duplicate of this issue (and PR), but would agree to
deprecate it.
More about WHY this option is WRONG and BAD will be added to MNG-7001.
> Mark command line option --legacy-local-repository as deprecated
> ----------------------------------------------------------------
>
> Key: MNG-6889
> URL: https://issues.apache.org/jira/browse/MNG-6889
> Project: Maven
> Issue Type: Task
> Components: Command Line
> Affects Versions: 3.6.3
> Reporter: Karl Heinz Marbaise
> Assignee: Karl Heinz Marbaise
> Priority: Minor
> Fix For: 4.0.x-candidate
>
>
> We should at least mark this option as deprecated or even better remove this
> option but this would be inconsistent to remove something which has not been
> marked deprecated before.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
