[
https://issues.apache.org/jira/browse/MNG-7713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694708#comment-17694708
]
ASF GitHub Bot commented on MNG-7713:
-------------------------------------
slawekjaranowski commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120679215
##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -256,8 +256,7 @@ public CLIManager() {
.build());
options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
.longOpt("legacy-local-repository")
- .desc(
- "Use Maven 2 Legacy Local Repository behaviour, ie no
use of _remote.repositories. Can also be activated by using
-Dmaven.legacyLocalRepo=true")
+ .desc("Ineffective, only kept for backward compatibility.")
Review Comment:
If such option will have no effect - why we want to preserve it ...
If user use it - it will not works as user expect - so we will have silently
different behavior that user think
For me will be better to drop at all - it will more clear for user and do
not make confusing
> Drop option legacy-local-repository
> -----------------------------------
>
> Key: MNG-7713
> URL: https://issues.apache.org/jira/browse/MNG-7713
> Project: Maven
> Issue Type: Task
> Components: Core
> Reporter: Tamas Cservenak
> Assignee: Tamas Cservenak
> Priority: Major
> Fix For: 3.9.1-candidate
>
>
> The option offers several ways to make Maven 3 use Maven 2 legacy local
> repository, the option help text states: "Use Maven 2 Legacy Local Repository
> behaviour, ie no use of _remote.repositories. Can also be activated by using
> -Dmaven.legacyLocalRepo=true".
> Let's drop this option, as there is no need to make Maven 3.9 support Maven 2
> local repository, that is (should be) transient anyway. Also, if really
> needed, there IS a resolver configuration that offers somewhat similar
> semantics, but Maven CLI should NOT advertise Maven 2 backward compatibility
> anymore.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
