[ 
https://issues.apache.org/jira/browse/MRESOLVER-328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17694926#comment-17694926
 ] 

ASF GitHub Bot commented on MRESOLVER-328:
------------------------------------------

michael-o commented on code in PR #255:
URL: https://github.com/apache/maven-resolver/pull/255#discussion_r1121339701


##########
maven-resolver-transport-http/src/test/java/org/eclipse/aether/transport/http/HttpTransporterTest.java:
##########
@@ -395,6 +395,27 @@ public void testGet_SSL() throws Exception {
         assertEquals(task.getDataString(), new 
String(listener.baos.toByteArray(), StandardCharsets.UTF_8));
     }
 
+    @Test
+    public void testGet_SelfSigned_SSL() throws Exception {
+        // client gets all the material removed (and later recreated)
+        System.clearProperty("javax.net.ssl.trustStore");
+        System.clearProperty("javax.net.ssl.trustStorePassword");
+        System.clearProperty("javax.net.ssl.keyStore");
+        System.clearProperty("javax.net.ssl.keyStorePassword");
+        session.setConfigProperty("aether.connector.http.ssl.insecure", true);

Review Comment:
   This is really, really ugly..., no?





> The transport-http should be able to ignore cert errors
> -------------------------------------------------------
>
>                 Key: MRESOLVER-328
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-328
>             Project: Maven Resolver
>          Issue Type: Improvement
>          Components: Resolver
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.6
>
>
> Like an "unsafe" or "insecure" SSL mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to