kriegaex commented on PR #110:
URL: 
https://github.com/apache/maven-shade-plugin/pull/110#issuecomment-1454779169

   Rebased on master, as requested by @michael-o. Actually, after 1.5 years of 
code rot, this was a pain in the neck to rebase. I am not even remembering 
exactly what I did back then and why exactly I did it the way I you see here. 
As a contributor who does not know the code base well, I would appreciate more 
timely responses and reviews, because repeatedly rebasing stuff is difficult 
and error-prone. The tests are still green, but I am not 100% sure if that 
means the patch is as perfect as it used to be. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to