psiroky commented on code in PR #799:
URL: https://github.com/apache/maven-mvnd/pull/799#discussion_r1126461087
##########
daemon/src/main/java/org/mvndaemon/mvnd/daemon/Server.java:
##########
@@ -233,7 +233,16 @@ private void accept() {
try {
while (true) {
try (SocketChannel socket = this.socket.accept()) {
- client(socket);
+ try {
+ // execute the client connection handling inside a new
thread to guard against possible
+ // ThreadLocal memory leaks
+ // see https://github.com/apache/maven-mvnd/issues/798
for more details
+ Thread handler = new Thread(() -> client(socket));
+ handler.start();
+ handler.join();
Review Comment:
This will block forever, so if the connection handling get stuck (a bug),
then this would never end. On the other hand, this is not changing the
behavior, it was like that before as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
