[
https://issues.apache.org/jira/browse/MNG-7724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697795#comment-17697795
]
ASF GitHub Bot commented on MNG-7724:
-------------------------------------
rmannibucau commented on code in PR #1041:
URL: https://github.com/apache/maven/pull/1041#discussion_r1129155652
##########
maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java:
##########
@@ -65,8 +67,14 @@ public static Slf4jConfiguration
getConfiguration(ILoggerFactory loggerFactory)
}
} catch (IOException | ClassNotFoundException | IllegalAccessException
| InstantiationException e) {
e.printStackTrace();
+ hadException = true;
}
- return new UnsupportedSlf4jBindingConfiguration(slf4jBinding,
supported);
+ return new UnsupportedSlf4jBindingConfiguration(
+ slf4jBinding,
+ supported,
Review Comment:
Not really, maven is wrong assuming it knows the entire ecosystem, it is
perfectly valid to use a slf4j binding maven does not know - or if you are
right it means we should drop slf4j from maven because we don't use the
abstraction at the end.
If it is right then we must not issue a warning (an error) when it is an
expected case - the use case triggering this change.
Guess it was more a default implementation than an intent to say a custom
binding is intended.
Assuming any custom binding will bring a custom maven integration is also a
high assumption for the little usage we do of that integration (a single CLI
toggle which is rarely used in practise) so hope we don't go that path which
would be the alternative.
> Slf4jConfigurationFactory should use info level when there is no exception
> and the logger type is unknown
> ---------------------------------------------------------------------------------------------------------
>
> Key: MNG-7724
> URL: https://issues.apache.org/jira/browse/MNG-7724
> Project: Maven
> Issue Type: Improvement
> Affects Versions: 4.0.0-alpha-4
> Reporter: Romain Manni-Bucau
> Priority: Minor
>
> As of now if we change the SLF4J bindings maven will issue warnings because a
> few features are disabled but due to the nature of switching these bindings
> it is highly likely it is intended and therefore the warning are misleading
> more than helping.
> The solution can be to log a warning if a configured factory fails to load
> but just log info when it succeeds.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
