rmannibucau commented on code in PR #1041:
URL: https://github.com/apache/maven/pull/1041#discussion_r1129421297
##########
maven-embedder/src/main/java/org/apache/maven/cli/logging/Slf4jConfigurationFactory.java:
##########
@@ -65,8 +67,14 @@ public static Slf4jConfiguration
getConfiguration(ILoggerFactory loggerFactory)
}
} catch (IOException | ClassNotFoundException | IllegalAccessException
| InstantiationException e) {
e.printStackTrace();
+ hadException = true;
}
- return new UnsupportedSlf4jBindingConfiguration(slf4jBinding,
supported);
+ return new UnsupportedSlf4jBindingConfiguration(
+ slf4jBinding,
+ supported,
Review Comment:
I rewrote the PR to not play with levels, please check the new proposal to
solve this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
