[ 
https://issues.apache.org/jira/browse/MWRAPPER-100?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17698292#comment-17698292
 ] 

ASF GitHub Bot commented on MWRAPPER-100:
-----------------------------------------

slawekjaranowski commented on code in PR #95:
URL: https://github.com/apache/maven-wrapper/pull/95#discussion_r1130739117


##########
maven-wrapper-plugin/pom.xml:
##########
@@ -50,16 +50,37 @@ under the License.
       <version>${mavenVersion}</version>
       <scope>provided</scope>
     </dependency>
+    <dependency>
+      <groupId>org.apache.maven</groupId>
+      <artifactId>maven-settings</artifactId>
+      <version>${mavenVersion}</version>
+      <scope>provided</scope>
+    </dependency>
     <dependency>
       <groupId>org.apache.maven.shared</groupId>
       <artifactId>maven-shared-utils</artifactId>
       <version>3.3.4</version>
     </dependency>
+    <dependency>
+      <groupId>javax.inject</groupId>
+      <artifactId>javax.inject</artifactId>
+      <version>1</version>
+    </dependency>
     <dependency>
       <groupId>org.codehaus.plexus</groupId>
       <artifactId>plexus-archiver</artifactId>
       <version>4.6.2</version>
     </dependency>
+    <dependency>
+      <groupId>org.codehaus.plexus</groupId>
+      <artifactId>plexus-io</artifactId>
+      <version>3.4.1</version>
+    </dependency>
+    <dependency>
+      <groupId>org.eclipse.aether</groupId>
+      <artifactId>aether-api</artifactId>

Review Comment:
   It is provided by core





> Declare needed dependencies
> ---------------------------
>
>                 Key: MWRAPPER-100
>                 URL: https://issues.apache.org/jira/browse/MWRAPPER-100
>             Project: Maven Wrapper
>          Issue Type: Dependency upgrade
>            Reporter: Elliotte Rusty Harold
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to