slachiewicz commented on code in PR #620:
URL: https://github.com/apache/maven-surefire/pull/620#discussion_r1133324999
##########
surefire-providers/surefire-junit-platform/src/test/java/org/apache/maven/surefire/junitplatform/RunListenerAdapterTest.java:
##########
@@ -630,9 +639,9 @@ private static TestIdentifier
newSourcelessChildIdentifierWithParent(
when(child.getSource()).thenReturn(Optional.empty());
when(child.getParent()).thenReturn(Optional.of(parent));
TestIdentifier childId = TestIdentifier.from(child);
-
- testPlan.add(childId);
- testPlan.add(parentId);
+ // TODO https://github.com/junit-team/junit5/issues/1732
Review Comment:
i'm not sure if my proposal to change from .add -> .addInternal is correct
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
