michael-o commented on code in PR #1064:
URL: https://github.com/apache/maven/pull/1064#discussion_r1143261715
##########
maven-core/src/main/java/org/apache/maven/toolchain/RequirementMatcherFactory.java:
##########
@@ -73,8 +73,6 @@ public boolean matches(String requirement) {
return range.getRecommendedVersion().compareTo(version) ==
0;
}
} catch (InvalidVersionSpecificationException ex) {
- // TODO error reporting
- ex.printStackTrace();
return false;
Review Comment:
If this information is required, it should be ad debug log level
##########
maven-core/src/test/java/org/apache/maven/repository/TestRepositorySystem.java:
##########
@@ -229,7 +229,7 @@ public ArtifactResolutionResult
resolve(ArtifactResolutionRequest request) {
.map(Dependency::new)
.collect(Collectors.toList());
} catch (IOException e) {
- e.printStackTrace();
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
