slawekjaranowski commented on code in PR #126:
URL:
https://github.com/apache/maven-assembly-plugin/pull/126#discussion_r1151163031
##########
src/main/java/org/apache/maven/plugins/assembly/artifact/DefaultDependencyResolver.java:
##########
@@ -130,10 +130,8 @@ void updateModuleSetResolutionRequirements( ModuleSet set,
DependencySet depende
{
if ( p.getArtifact() == null )
{
- // TODO: such a call in MavenMetadataSource too -
packaging not really the intention of type
- final Artifact artifact =
- resolver.createArtifact( p.getGroupId(),
p.getArtifactId(), p.getVersion(), p.getPackaging() );
- p.setArtifact( artifact );
+ p.setArtifact( artifactFactory.createBuildArtifact(
p.getGroupId(), p.getArtifactId(),
Review Comment:
`ArtifactFactory` is also deprecated, I would like to try `new
DefaultArtifact(...)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
