gnodet commented on PR #73:
URL: https://github.com/apache/maven-filtering/pull/73#issuecomment-1491378702

   > > The change has the same effect as if always using `overwrite=true`, but 
only if the content has changed. If the content is unchanged, the file will not 
be modified and will not trigger downstream processing based on last modified 
time. Note that the `overwrite` flag was only effective when _not_ filtering, 
which was incoherent too.
   > 
   > not sure exactly about the use case. what do you mean with `content`? in 
case of a pom with `<properties> <foo>bar</bar> </properties>` a file is 
filtering using this property. second run using `mvn ..... -Dfoo=blabla` 
Technically the content of the file hasn’t changed but the properties for 
filtering have. if I remember correctly it was a reason why it was different in 
case of filtering activated or not.
   
   By content, I refer to what is actually _written_ to the file. This any 
transformation which happen before writing to the file will be completely taken 
into account.  The caching stream simply avoid rewriting the _exact_ same file 
again and again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to