[
https://issues.apache.org/jira/browse/MPLUGIN-457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17712713#comment-17712713
]
ASF GitHub Bot commented on MPLUGIN-457:
----------------------------------------
michael-o commented on code in PR #201:
URL:
https://github.com/apache/maven-plugin-tools/pull/201#discussion_r1167627287
##########
maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/JavaAnnotationsMojoDescriptorExtractor.java:
##########
@@ -570,23 +572,26 @@ protected void extendJavaProjectBuilderWithSourcesJar(
JavaProjectBuilder builder, Artifact artifact, PluginToolsRequest
request, String classifier)
throws ExtractionException {
try {
- Artifact sourcesArtifact =
repositorySystem.createArtifactWithClassifier(
+ org.eclipse.aether.artifact.Artifact sourcesArtifact = new
DefaultArtifact(
artifact.getGroupId(),
artifact.getArtifactId(),
- artifact.getVersion(),
- artifact.getType(),
- classifier);
-
- ArtifactResolutionRequest req = new ArtifactResolutionRequest();
- req.setArtifact(sourcesArtifact);
- req.setLocalRepository(request.getLocal());
- req.setRemoteRepositories(request.getRemoteRepos());
- ArtifactResolutionResult res = repositorySystem.resolve(req);
- if (res.hasMissingArtifacts() || res.hasExceptions()) {
- getLogger()
- .warn("Unable to get sources artifact for " +
artifact.getGroupId() + ":"
- + artifact.getArtifactId() + ":" +
artifact.getVersion()
- + ". Some javadoc tags (@since, @deprecated
and comments) won't be used");
+ classifier,
+ artifact.getArtifactHandler().getExtension(),
+ artifact.getVersion());
+
+ ArtifactRequest resolveRequest =
+ new ArtifactRequest(sourcesArtifact,
request.getProject().getRemoteProjectRepositories(), null);
+ try {
+ ArtifactResult result =
repositorySystem.resolveArtifact(request.getRepoSession(), resolveRequest);
+ sourcesArtifact = result.getArtifact();
+ } catch (ArtifactResolutionException e) {
+ String message = "Unable to get sources artifact for " +
artifact.getId()
+ + ". Some javadoc tags (@since, @deprecated and
comments) won't be used";
+ if (getLogger().isDebugEnabled()) {
+ getLogger().debug(message, e);
Review Comment:
Please leave the level at warn, but it will contain more information.
> Use Resolver API, get rid of localRepository
> --------------------------------------------
>
> Key: MPLUGIN-457
> URL: https://issues.apache.org/jira/browse/MPLUGIN-457
> Project: Maven Plugin Tools
> Issue Type: Improvement
> Reporter: Slawomir Jaranowski
> Assignee: Slawomir Jaranowski
> Priority: Major
> Fix For: next-release
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
