michael-o commented on code in PR #182:
URL: https://github.com/apache/maven-release/pull/182#discussion_r1171259426


##########
maven-release-manager/src/main/java/org/apache/maven/shared/release/exec/ForkedMavenExecutor.java:
##########
@@ -106,6 +106,10 @@ public void executeGoals(
 
             cl.addEnvironment("MAVEN_TERMINATE_CMD", "on");
 
+            if (releaseEnvironment.getJavaHome() != null) {
+                cl.addEnvironment("JAVA_HOME", 
releaseEnvironment.getJavaHome().getAbsolutePath());

Review Comment:
   I'd expect that always an absolute file is provided, no?
   
   Moreover, this value is always populated due to the default value, no?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to