[
https://issues.apache.org/jira/browse/MBUILDCACHE-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17716782#comment-17716782
]
ASF GitHub Bot commented on MBUILDCACHE-39:
-------------------------------------------
AlexanderAshitkin commented on code in PR #69:
URL:
https://github.com/apache/maven-build-cache-extension/pull/69#discussion_r1169467126
##########
src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java:
##########
@@ -667,8 +663,11 @@ private SortedMap<String, String> getMutableDependencies()
throws IOException {
String projectHash;
if (dependencyProject != null) // part of multi module
{
- projectHash =
-
projectInputCalculator.calculateInput(dependencyProject).getChecksum();
+ // To avoid the current module (B) to be re-built if it
depends on a module (A) of the current project
+ // which has some of its files edited.
+ // It would have no sense to re-build module B just because
module A was edited.
+ // More info:
https://issues.apache.org/jira/projects/MBUILDCACHE/issues/MBUILDCACHE-54
+ continue;
Review Comment:
This is wrong - please see the jira comment.
> Upgrade to maven-parent pom 39
> ------------------------------
>
> Key: MBUILDCACHE-39
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-39
> Project: Maven Build Cache Extension
> Issue Type: Dependency upgrade
> Reporter: Guillaume Nodet
> Assignee: Guillaume Nodet
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0.1
>
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
