[ 
https://issues.apache.org/jira/browse/MNG-6303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17719766#comment-17719766
 ] 

ASF GitHub Bot commented on MNG-6303:
-------------------------------------

michael-o commented on code in PR #1062:
URL: https://github.com/apache/maven/pull/1062#discussion_r1185874264


##########
maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java:
##########
@@ -31,16 +31,8 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.nio.file.Paths;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashSet;
-import java.util.LinkedHashMap;
-import java.util.List;
-import java.util.Map;
+import java.util.*;

Review Comment:
   OK, if spotless does not complain, I won't either, but that's not the usual 
approach for our code.





> .mvn/jvm.config and .mvn/maven.config should allow to resolve environment 
> variables
> -----------------------------------------------------------------------------------
>
>                 Key: MNG-6303
>                 URL: https://issues.apache.org/jira/browse/MNG-6303
>             Project: Maven
>          Issue Type: New Feature
>          Components: Bootstrap & Build
>    Affects Versions: 3.5.0
>            Reporter: Konrad Windszus
>            Priority: Major
>
> With the mechanism of having project-specific maven options being specified 
> in {{.mvn/maven.config}} and {{.mvn/jvm.config}} (MNG-6267) it is often handy 
> to share those settings among multiple developers (i.e. via maintaining it 
> via the SCM). Unfortunately the mechanism does not support resolving 
> environment variables, which makes it hard to deal with user-specific 
> directories or settings. Please support resolving environment variables 
> through a special pattern like {{$ENV_NAME}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to