[
https://issues.apache.org/jira/browse/MNG-7740?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17721453#comment-17721453
]
ASF GitHub Bot commented on MNG-7740:
-------------------------------------
Giovds commented on code in PR #1105:
URL: https://github.com/apache/maven/pull/1105#discussion_r1190114383
##########
maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java:
##########
@@ -77,13 +80,34 @@ public void injectTransformedArtifacts(MavenProject
project, RepositorySystemSes
Files.createDirectories(buildDir);
generatedFile = Files.createTempFile(buildDir,
CONSUMER_POM_CLASSIFIER, "pom");
Review Comment:
This was added in [MNG-7622](https://issues.apache.org/jira/browse/MNG-7622)
at [this
line](https://github.com/apache/maven/pull/907/files#diff-b0e0e02760045bbda4d9839297d968b0218de307f1c4a35a3262d8cb406e0ea3R70).
The newly created files currently are extensionless and suffixed `pom` (see
screenshot 1).
If I suffix the newly created files with `.pom` it will be seen as a `POM`
extension in my file explorer (screenshot 2).
Would this not be a different ticket to change that behaviour? I'm happy to
change it here if not, but I'll have to check if it impacts other places.
[1]
<img width="533" alt="image"
src="https://github.com/apache/maven/assets/27761321/9e64036a-ff9e-482f-9122-71412b113aa1";>
[2]
<img width="449" alt="image"
src="https://github.com/apache/maven/assets/27761321/eeb2b124-a48c-44d0-b81d-5631814a5a25";>
<img width="592" alt="image"
src="https://github.com/apache/maven/assets/27761321/809f2d4a-a041-4095-8f3e-30881a36dda5";>
> Target directory is flooded with consumer*pom files
> ---------------------------------------------------
>
> Key: MNG-7740
> URL: https://issues.apache.org/jira/browse/MNG-7740
> Project: Maven
> Issue Type: Improvement
> Components: build/consumer, Core
> Affects Versions: 4.0.0-alpha-4
> Environment: Apache Maven 4.0.0-alpha-4
> (009cf4a7213aead8a7946a2397e2396c5927f30f)
> Maven home: /Users/maarten/Tools/apache-maven-4.0.0-alpha-4
> Java version: 17.0.6, vendor: Eclipse Adoptium, runtime:
> /Library/Java/JavaVirtualMachines/temurin-17.jdk/Contents/Home
> Default locale: en_NL, platform encoding: UTF-8
> OS name: "mac os x", version: "13.2.1", arch: "aarch64", family: "mac"
> Reporter: Maarten Mulders
> Priority: Minor
> Labels: up-for-grabs
>
> After invoking Mavens {{validate}} or later lifecycle phase, there is a
> *consumerXXXpom* file left in the build directory. Here, XXX is a bunch of
> numbers.
> It is not harmful, but I dislike the fact that for every invocation of Maven,
> the file gets generated again and again. This can quickly lead to tens of
> files that are never used again anymore. I feel we should clean those files
> when we're done using them.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
