[ 
https://issues.apache.org/jira/browse/MNG-6829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17725378#comment-17725378
 ] 

ASF GitHub Bot commented on MNG-6829:
-------------------------------------

timtebeek commented on PR #58:
URL: 
https://github.com/apache/maven-install-plugin/pull/58#issuecomment-1559140528

   @elharo I notice that my commit message didn't make it into the created pull 
request message, so you might not be aware of some of these last open pull 
requests. Would you mind going through [this last 
batch](https://github.com/pulls?q=is%3Aopen+is%3Apr+archived%3Afalse+%22mng-6829%22+author%3Atimtebeek)?
   
   > Last batch of is(Not)Empty for 
https://issues.apache.org/jira/browse/MNG-6829
   These are the smallest change sets, hence why I opened more at the same time.
   After this we can target the next most often used method from the 
StringUtils classes.
   




> Remove commons-lang3 dependency
> -------------------------------
>
>                 Key: MNG-6829
>                 URL: https://issues.apache.org/jira/browse/MNG-6829
>             Project: Maven
>          Issue Type: Sub-task
>          Components: Bootstrap & Build
>    Affects Versions: 3.6.3
>            Reporter: Karl Heinz Marbaise
>            Assignee: Karl Heinz Marbaise
>            Priority: Minor
>              Labels: close-pending
>             Fix For: 4.0.x-candidate
>
>         Attachments: dtPKn.xlsx
>
>
> Currently we use {{commons-lang3}} for the following classes
> * {{StringUtils}} can be replaced by usage of either {{plexus-utils}} or 
> {{maven-shared-utils}} or as I tested with self implementation
> * {{SystemUtils}} is only used in some tests which can simply replaced by 
> using JUnit Jupiter with all the support it has.
> * {{Validate}} is a precondition class which checks for parameters etc. can 
> be implemented very easily (done already to see how it works). Later this 
> could be made part of {{maven-shared-utils}}.
> * Currently the {{StringUtils.substringAfterLast( resourceName,  "/" )}} is 
> used in {{ConsoleMavenTransferListener}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to