[
https://issues.apache.org/jira/browse/SUREFIRE-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726362#comment-17726362
]
ASF GitHub Bot commented on SUREFIRE-2164:
------------------------------------------
slawekjaranowski commented on code in PR #645:
URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205911407
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw,
WrappedReportEntry report) throws I
ppw.addAttribute("classname", extraEscapeAttribute(className));
}
- ppw.addAttribute("time", report.elapsedTimeAsString());
+ if (report.getElapsed() != null) {
+ ppw.addAttribute("time", String.valueOf(report.getElapsed() /
ONE_SECOND));
Review Comment:
This can depend on user locales like use dot or comma as separator - should
we take care about it?
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw,
WrappedReportEntry report) throws I
ppw.addAttribute("classname", extraEscapeAttribute(className));
}
- ppw.addAttribute("time", report.elapsedTimeAsString());
Review Comment:
Can we remove method `elapsedTimeAsString` and used
`org.apache.maven.plugin.surefire.report.ReporterUtils`?
> Simplify serialization of elapsed time in StatelessXmlReporter
> --------------------------------------------------------------
>
> Key: SUREFIRE-2164
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2164
> Project: Maven Surefire
> Issue Type: Improvement
> Components: xml generation
> Affects Versions: 3.1.0
> Reporter: Michael Osipov
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.1.1
>
>
> The current code uses a convoluted solution based on {{NumberFormat}} which
> refers to an outdated defintion on Ant's XML report file. These days, we can
> use {{String#valueOf()}} to serialize the string representation of a float
> value since:
> * Easier to understand and this is not human output (separation of concerns)
> * Ant's XMLJUnitResultFormatter does exactly the same with a double value.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
