michael-o commented on code in PR #645:
URL: https://github.com/apache/maven-surefire/pull/645#discussion_r1205932070
##########
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##########
@@ -387,7 +390,9 @@ private void startTestElement(XMLWriter ppw,
WrappedReportEntry report) throws I
ppw.addAttribute("classname", extraEscapeAttribute(className));
}
- ppw.addAttribute("time", report.elapsedTimeAsString());
Review Comment:
No, we can't. See here:
https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR185
In fact, this subsequent commit makes `ReporterUtils` superfluous. My object
was to clearly seperate serialization/deserialization of machine data (which
are never locale-specific, but neutral), rendering happens in the view layer:
https://github.com/apache/maven-surefire/pull/635/commits/9dab367d7e200022b4e88eb58cdfcf281824a124#diff-efbf1a613b0d3b854d7a732ab8f6221fa5ac34210449cdfb4eee6bb61a60c1ccR59-R61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
