gnodet commented on code in PR #1128:
URL: https://github.com/apache/maven/pull/1128#discussion_r1206419439
##########
maven-core/src/main/java/org/apache/maven/plugin/internal/DefaultPluginValidationManager.java:
##########
@@ -247,7 +247,11 @@ private String pluginOccurrence(MavenSession mavenSession)
{
File currentPom = prj.getFile();
if (currentPom != null) {
File rootBasedir = mavenSession.getTopLevelProject().getBasedir();
- result += " (" +
rootBasedir.toPath().relativize(currentPom.toPath()) + ")";
+ if (currentPom.getPath().startsWith(rootBasedir.getPath())) {
Review Comment:
I think we need to be consistent with
https://github.com/apache/maven/blob/e9d570889ffce29c3f92494510499ae0e32a02cf/maven-embedder/src/main/java/org/apache/maven/cli/event/ExecutionEventLogger.java#L299-L300
So better continue using the top directory. However, does the
ExecutionEventLogger suffer from the same problem ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
