[ 
https://issues.apache.org/jira/browse/MRESOLVER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17726680#comment-17726680
 ] 

Tamas Cservenak edited comment on MRESOLVER-363 at 5/26/23 4:48 PM:
--------------------------------------------------------------------

1. yes
2. that's exactly what happens (with a twist: file is not present -> go grab 
it; file is present but no lastUpdated -> let policy decide)

(note: "file" here denotes artifact or metadata XML, while 
resolver-status.properties is like meta-metadata here, so existence is NOT 
about properties file but about payload, the artifact or metadata XML)

See this change from today 
https://github.com/apache/maven-resolver/commit/466f419fc80734252591a34f29a2fc500de8bff2
 and related class.

Also observe this UT, that would fail if in case TS_NEVER would be returned 
instead of TS_UNKNOWN
https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java#L427


was (Author: cstamas):
1. yes
2. that's exactly what happens (with a twist: file is not present -> go grab 
it; file is present but no lastUpdated -> let policy decide)

See this change from today 
https://github.com/apache/maven-resolver/commit/466f419fc80734252591a34f29a2fc500de8bff2
 and related class.

Also observe this UT, that would fail if in case TS_NEVER would be returned 
instead of TS_UNKNOWN
https://github.com/apache/maven-resolver/blob/master/maven-resolver-impl/src/test/java/org/eclipse/aether/internal/impl/DefaultUpdateCheckManagerTest.java#L427

> Maven metadata is not updated in some cases
> -------------------------------------------
>
>                 Key: MRESOLVER-363
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-363
>             Project: Maven Resolver
>          Issue Type: Bug
>    Affects Versions: 1.9.10
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>
> Seems when update check for metadata happens, and:
>  * maven-metadata XML is present, but
>  * resolver-status.properties is not, OR was created by maven-compat, that 
> uses different key for lastUpdated. Effectively the value of lastUpdated is 
> not present.
> The update check falsely DO NOT check for update, as it will end up with 
> update policy "never" in update policy analyzer.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to