gnodet commented on code in PR #1129:
URL: https://github.com/apache/maven/pull/1129#discussion_r1208618008
##########
maven-toolchain-builder/src/main/java/org/apache/maven/toolchain/building/DefaultToolchainsBuilder.java:
##########
@@ -54,23 +55,44 @@ public class DefaultToolchainsBuilder implements
ToolchainsBuilder {
private final MavenToolchainMerger toolchainsMerger = new
MavenToolchainMerger();
private final ToolchainsWriter toolchainsWriter;
private final ToolchainsReader toolchainsReader;
+ private final List<ToolchainDiscoverer> toolchainDiscoverers;
@Inject
- public DefaultToolchainsBuilder(ToolchainsWriter toolchainsWriter,
ToolchainsReader toolchainsReader) {
+ public DefaultToolchainsBuilder(
+ ToolchainsWriter toolchainsWriter,
+ ToolchainsReader toolchainsReader,
+ List<ToolchainDiscoverer> toolchainDiscoverers) {
this.toolchainsWriter = toolchainsWriter;
this.toolchainsReader = toolchainsReader;
+ this.toolchainDiscoverers = toolchainDiscoverers;
}
@Override
public ToolchainsBuildingResult build(ToolchainsBuildingRequest request)
throws ToolchainsBuildingException {
ProblemCollector problems = ProblemCollectorFactory.newInstance(null);
+ PersistedToolchains discoveredToolchains = null;
+ if (toolchainDiscoverers != null) {
+ for (ToolchainDiscoverer discoverer : toolchainDiscoverers) {
+ PersistedToolchains toolchains =
discoverer.discoverToolchains();
+ if (toolchains != null) {
Review Comment:
Sounds good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
