[ 
https://issues.apache.org/jira/browse/MSHARED-1251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17727134#comment-17727134
 ] 

ASF GitHub Bot commented on MSHARED-1251:
-----------------------------------------

elharo commented on code in PR #33:
URL: https://github.com/apache/maven-archiver/pull/33#discussion_r1209439247


##########
src/main/java/org/apache/maven/archiver/MavenArchiveConfiguration.java:
##########
@@ -35,6 +35,10 @@ public class MavenArchiveConfiguration {
 
     private boolean recompressAddedZips = true;
 
+    /**
+     * @deprecated See <a 
href="https://bugs.openjdk.org/browse/JDK-8305597";>JDK-8305597</a>
+     */
+    @Deprecated

Review Comment:
   Deprecating the method is enough. Private fields can be changed freely 
without worrying about compatibility when they're no longer used. Adding 
Javadoc to private fields, deprecation warnings included, is painting the lily. 





> Deprecate the JAR Index feature (JDK-8302819)
> ---------------------------------------------
>
>                 Key: MSHARED-1251
>                 URL: https://issues.apache.org/jira/browse/MSHARED-1251
>             Project: Maven Shared Components
>          Issue Type: New Feature
>          Components: maven-archiver
>            Reporter: Slawomir Jaranowski
>            Priority: Major
>
> See https://bugs.openjdk.org/browse/JDK-8305597



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to