[GitHub] [maven-project-info-reports-plugin] michael-o commented on pull request #47: [MPIR-431] Dependency file details section: segregate Java version

Wed, 31 May 2023 00:48:59 -0700 


michael-o commented on PR #47:
URL: 
https://github.com/apache/maven-project-info-reports-plugin/pull/47#issuecomment-1569671450

   Idiotlike approach:
   ```
   diff --git 
a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
 
b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
   index d4c6b84..7f2694b 100644
   --- 
a/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
   +++ 
b/src/main/java/org/apache/maven/report/projectinfo/dependencies/renderer/DependenciesRenderer.java
   @@ -1386,9 +1386,11 @@ public class DependenciesRenderer extends 
AbstractProjectInfoRenderer {
            }
   
            void addTotal(long add, String scope) {
   -            SummaryTableRowOrder.TOTALS.addTotal(this, add);
                SummaryTableRowOrder currentRow = 
SummaryTableRowOrder.fromScope(scope);
   -            currentRow.addTotal(this, add);
   +            if (currentRow != null) {
   +                SummaryTableRowOrder.TOTALS.addTotal(this, add);
   +                currentRow.addTotal(this, add);
   +            }
            }
   
            /** {@inheritDoc} */
   ```
   
   What I have noticed:
   
![grafik](https://github.com/apache/maven-project-info-reports-plugin/assets/573017/f3e02cd0-281d-4bf9-8640-ebab0622f2b3)
   
   The debug column value does not make sense if no Java version could be 
determined.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to