martin-g commented on code in PR #155:
URL:
https://github.com/apache/maven-apache-parent/pull/155#discussion_r1218981357
##########
pom.xml:
##########
@@ -96,6 +96,34 @@ under the License.
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and
surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version><!-- for
m-plugin-p and maven-plugin-annotations -->
<assembly.tarLongFileMode>posix</assembly.tarLongFileMode>
+
+ <!-- plugins versions -->
+ <apacheRatPluginVersion>0.15</apacheRatPluginVersion>
+ <mavenAntrunPluginVersion>3.1.0</mavenAntrunPluginVersion>
+ <mavenAssemblyPluginVersion>3.6.0</mavenAssemblyPluginVersion>
+ <mavenCleanPluginVersion>3.2.0</mavenCleanPluginVersion>
+ <mavenCompilerPluginVersion>3.11.0</mavenCompilerPluginVersion>
+ <mavenDependencyPluginVersion>3.6.0</mavenDependencyPluginVersion>
+ <mavenDeployPluginVersion>3.1.1</mavenDeployPluginVersion>
+ <mavenEarPluginVersion>3.3.0</mavenEarPluginVersion>
+ <mavenEnforcerPluginVersion>3.3.0</mavenEnforcerPluginVersion>
+ <mavenGpgPluginVersion>3.1.0</mavenGpgPluginVersion>
+ <mavenHelpPluginVersion>3.4.0</mavenHelpPluginVersion>
+ <mavenInstallPluginVersion>3.1.1</mavenInstallPluginVersion>
+ <mavenInvokerPluginVersion>3.5.1</mavenInvokerPluginVersion>
+ <mavenJarPluginVersion>3.3.0</mavenJarPluginVersion>
+ <mavenJavadocPluginVersion>3.5.0</mavenJavadocPluginVersion>
+
<mavenProjectInfoReportsPluginVersion>3.4.3</mavenProjectInfoReportsPluginVersion>
+ <mavenReleasePluginVersion>3.0.0</mavenReleasePluginVersion>
+
<mavenRemoteResourcesPluginVersion>3.1.0</mavenRemoteResourcesPluginVersion>
+ <mavenResourcesPluginVersion>3.3.1</mavenResourcesPluginVersion>
+ <mavenScmPluginVersion>2.0.1</mavenScmPluginVersion>
+ <mavenScmPublishPluginVersion>3.2.1</mavenScmPublishPluginVersion>
+ <mavenShadePluginVersion>3.4.1</mavenShadePluginVersion>
+ <mavenSitePluginVersion>3.12.1</mavenSitePluginVersion>
+ <mavenSourcePluginVersion>3.3.0</mavenSourcePluginVersion>
+ <mavenWarPluginVersion>3.3.2</mavenWarPluginVersion>
Review Comment:
> perso I usually use `<artifactId>.version` such
`<maven-release-plugin.version>`
> it looks more similar to `object.property`
+1
What about the old properties ?
```
<surefire.version>3.1.0</surefire.version><!-- for surefire, failsafe and
surefire-report -->
<maven.plugin.tools.version>3.9.0</maven.plugin.tools.version>
```
Are you going to change them to be consistent with the new ones ? Any
concerns about backward compatibility ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
