[jira] [Commented] (MNG-5789) README.txt in distro doesn't say Maven 3.3.1 requires JDK 1.7

[ASF GitHub Bot (Jira)]

    [ 
https://issues.apache.org/jira/browse/MNG-5789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17729992#comment-17729992
 ] 

ASF GitHub Bot commented on MNG-5789:
-------------------------------------

gnodet commented on code in PR #1145:
URL: https://github.com/apache/maven/pull/1145#discussion_r1221092114


##########
maven-plugin-api/src/main/mdo/plugin.mdo:
##########
@@ -24,9 +24,10 @@ under the License.
   <description><![CDATA[
     Plugin descriptor, stored in <code>META-INF/maven/plugin.xml</code> in a 
plugin's jar artifact.
     This descriptor is generally generated from plugin sources, using
-    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>.
-    <p><i>Notice:</i> this documentation is generated from a Modello model but 
the code executed is not generated
-    from this descriptor. Please report if you find anything wrong.</p>
+    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>, but other 
tools may geenrated it or it could even be hand-written.

Review Comment:
   geenrated  -> generated



##########
maven-plugin-api/src/main/mdo/plugin.mdo:
##########
@@ -24,9 +24,10 @@ under the License.
   <description><![CDATA[
     Plugin descriptor, stored in <code>META-INF/maven/plugin.xml</code> in a 
plugin's jar artifact.
     This descriptor is generally generated from plugin sources, using
-    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>.
-    <p><i>Notice:</i> this documentation is generated from a Modello model but 
the code executed is not generated
-    from this descriptor. Please report if you find anything wrong.</p>
+    <a href="/plugins/maven-plugin-plugin/">maven-plugin-plugin</a>, but other 
tools may geenrated it or it could even be hand-written.

Review Comment:
   I'm not really about adding the sentence that `other tools may generated it 
or it could even be hand-written`.  Maybe I'm wrong, but I'm not aware of any 
such tools.  If there's none, this becomes irrelevant.
   Also from an API point of view, I would consider the xml plugin descriptor 
an internal technical feature, rather than a user facing API, as really, users 
don't manipulate or see it.  It just happens to be generated by the tooling 
provided by maven and understood by maven itself.





> README.txt in distro doesn't say Maven 3.3.1 requires JDK 1.7
> -------------------------------------------------------------
>
>                 Key: MNG-5789
>                 URL: https://issues.apache.org/jira/browse/MNG-5789
>             Project: Maven
>          Issue Type: Bug
>          Components: General
>    Affects Versions: 3.3.1
>         Environment: n/a
>            Reporter: Anders Hammar
>            Assignee: Jason van Zyl
>            Priority: Major
>
> README.txt needs to be updated to specify that Maven 3.3+ requires JDK 1.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)