[
https://issues.apache.org/jira/browse/MNG-5697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17731171#comment-17731171
]
Herve Boutemy commented on MNG-5697:
------------------------------------
I did more extensive tests to better clarify:
- my own mistakes (I completely misunderstood classloading: plugins are Build
Extensions, not Core Extensions, thanks for clarifications in MNG-7574)
- from real problems
here are my tests: https://github.com/hboutemy/MNG-5697
There are 2 completely different aspects:
- packaging: previous comment explains it, it can be ok to remove some
packaging from core (with proper documentation/communication), it will cost
reasonable added complexity to users (declaring plugins). But NOT on jar
- artifact handlers/dependency type: here, I feel that the whole replacement
from core to packaging plugins is completely unintuitive to users, and really
adds complexity and strange behaviours when not configure properly
I just did unit tests for now (mono-module project, one packaging, one
dependency type), I need some time to test at larger scale to check there are
no other issues (I still feel that there may be edge cases: I know i need to
nail them down...)
> remove LifecycleMapping and ArtifactHandler from maven-core: move to target
> packaging plugin
> --------------------------------------------------------------------------------------------
>
> Key: MNG-5697
> URL: https://issues.apache.org/jira/browse/MNG-5697
> Project: Maven
> Issue Type: Improvement
> Components: Plugins and Lifecycle
> Reporter: Robert Scholte
> Priority: Major
> Fix For: 4.x / Backlog
>
>
> Maven Core should only be aware of the pom packaging details, the rest of the
> {{ArtifactHandlers}} and {{LifecycleMappings}} should be moved to their own
> packaging plugin:
> - jar packaging: maven-jar-plugin
> - ejb and ejb3 packagings: maven-ejb-plugin
> - maven-plugin packaging: maven-plugin-plugin
> - war packaging: maven-war-plugin
> - ear packaging: maven-ear-plugin
> - rar packaging: maven-rar-plugin
> - par packaging: ?
> {{LifecycleMappings}}
> http://maven.apache.org/ref/3.2.5/maven-core/default-bindings.html
> {{ArtifactHandlers}}
> http://maven.apache.org/ref/3.2.5/maven-core/artifact-handlers.html
> *Maven core should then get the lifecycle mappings and artifact handlers
> configurations from the plugin at the beginning of the build, before begin
> able to calculate the build plan*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
